[
https://issues.apache.org/jira/browse/YARN-9664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16918247#comment-16918247
]
Tao Yang commented on YARN-9664:
--------------------------------
Thanks [~cheersyang] for the review.
{quote}
ActivitiesUtils Line 56: I noticed that the 1st filter is to filter out null
objects
{quote}
Aim of that is to filter out node-level activities instead of null objects, we
use {{e.getNodeId() != null}} since only node-level activities has non-null
nodeIds.
{quote}
what does "single placement node" mean here?
{quote}
"single placement node" means this scheduling process is based on a single
node, I want to use it to distinguish from multi-nodes placement scenarios,
however it seems not suitable, I'll be glad if you have better description for
it.
{quote}
"Node skipped because of no off-switch and locality violation"
I am also not quite sure what does this mean, can you please elaborate?
{quote}
It means request have only node_local type or rack_local type but no off-switch
type, and node/rack locality can't be satisfied.
{quote}
line 650: is it safe to the check: "if (node != null && !isReserved)" here?
{quote}
I think there is no need to add the check above. No matter whether node is null
and what type is the assignment, activities which is required should be
finished when reaching here.
Others are fine for me, I will update the patch after all points above are
confirmed. Thanks.
> Improve response of scheduler/app activities for better understanding
> ---------------------------------------------------------------------
>
> Key: YARN-9664
> URL: https://issues.apache.org/jira/browse/YARN-9664
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Tao Yang
> Assignee: Tao Yang
> Priority: Major
> Attachments: YARN-9664.001.patch, YARN-9664.002.patch
>
>
> Currently some diagnostics are not easy enough to understand for common
> users, and I found some places still need to be improved such as no partition
> information and lacking of necessary activities. This issue is to improve
> these shortcomings.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
