[
https://issues.apache.org/jira/browse/YARN-9761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16919921#comment-16919921
]
Jonathan Hung commented on YARN-9761:
-------------------------------------
Thanks [~pralabhkumar]. Looks good in general. Can you fix the checkstyle
issues?
Other nits:
* ClientRMService: let's add a newline between {noformat}private
ReservationInputValidator rValidator;
private SubmissionContextPreProcessor contextPreProcessor;{noformat} so people
don't think it's part of the reservation APIs
* Let's revert the whitespace change in ClientRMService#renewDelegationToken
* These fields can be final in SubmissionContextPreProcessor: {noformat}
private static Logger LOG = LoggerFactory.getLogger(
SubmissionContextPreProcessor.class);
private static String DEFAULT_COMMANDS = "*";{noformat}
* There's a bunch of unnecessary whitespace changes in TestClientRMService, can
we revert those?
* I don't think we need the stuff added at the beginning of TestClientRMService
(dtsm, kerberosRule, setup/teardownSecretManager), can we remove those?
> Allow overriding application submissions based on server side configs
> ---------------------------------------------------------------------
>
> Key: YARN-9761
> URL: https://issues.apache.org/jira/browse/YARN-9761
> Project: Hadoop YARN
> Issue Type: New Feature
> Reporter: Jonathan Hung
> Assignee: pralabhkumar
> Priority: Major
> Labels: release-blocker
> Attachments: YARN-9761.01.patch, YARN-9761.02.patch
>
>
> Create a preprocessor/interceptor which takes each app submitted to RM and
> overrides the submission context based on server side configs.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
