[ 
https://issues.apache.org/jira/browse/YARN-9761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16923685#comment-16923685
 ] 

Jonathan Hung commented on YARN-9761:
-------------------------------------

Thanks [~pralabhkumar] +1 on the 06 patch.

**This patch doesn't apply to branch-3.1 cleanly:
{noformat}
[ERROR] 
/Users/jhung/hadoop/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestClientRMService.java:[967,35]
 cannot find symbol
  symbol:   method mockResourceScheduler()
  location: class 
org.apache.hadoop.yarn.server.resourcemanager.TestClientRMService {noformat}
 

Seems TestClientRMService changed from mockYarnScheduler to 
mockResourceScheduler in YARN-8468. Can you upload a branch-3.1 patch which 
uses mockYarnScheduler in branch-3.1?

After fixing that, there's another issue in branch-2:
{noformat}
[ERROR] 
/Users/jhung/hadoop/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestClientRMService.java:[689,12]
 incompatible types: java.lang.Object cannot be converted to 
java.util.List<java.lang.String>{noformat}
Seems the
{noformat}
     QueueACLsManager mockQueueACLsManager = mock(QueueACLsManager.class);
     when(mockQueueACLsManager.checkAccess(any(UserGroupInformation.class),
         any(QueueACL.class), any(RMApp.class), any(String.class),
         any())) {noformat}
bit in TestClientRMService won't work in branch-2. Can you upload a branch-2 
patch which changes the last any() to use anyListOf(String.class)?

> Allow overriding application submissions based on server side configs
> ---------------------------------------------------------------------
>
>                 Key: YARN-9761
>                 URL: https://issues.apache.org/jira/browse/YARN-9761
>             Project: Hadoop YARN
>          Issue Type: New Feature
>            Reporter: Jonathan Hung
>            Assignee: pralabhkumar
>            Priority: Major
>              Labels: release-blocker
>         Attachments: YARN-9761.01.patch, YARN-9761.02.patch, 
> YARN-9761.03.patch, YARN-9761.04.patch, YARN-9761.05.patch, YARN-9761.06.patch
>
>
> Create a preprocessor/interceptor which takes each app submitted to RM and 
> overrides the submission context based on server side configs.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to