[
https://issues.apache.org/jira/browse/YARN-10084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17020416#comment-17020416
]
Jim Brennan commented on YARN-10084:
------------------------------------
Thanks for the patch [~epayne]! I've built and run the tests and overall this
looks good to me.
One question though: in setupQueueConfigs, should you be checking for {{>= 0}}
instead of {{>0}} in these conditionals?
{noformat}
if (maxApplicationLifetime > 0 &&
defaultApplicationLifetime > maxApplicationLifetime) {
throw new YarnRuntimeException(
"Default lifetime " + defaultApplicationLifetime
+ " can't exceed maximum lifetime " + maxApplicationLifetime);
}
defaultApplicationLifetime = defaultApplicationLifetime > 0
? defaultApplicationLifetime : maxApplicationLifetime;
{noformat}
I'm not sure what zero means exactly - seems like it should disable it, but
invalid is -1, and in getInheritedMaxAppLifetime we use {{maxAppLifetime >=
0}}. Meanwhile in checkAndGetApplicaitonLifetime we treat both -1 and 0 as
invalid.
> Allow inheritance of max app lifetime / default app lifetime
> ------------------------------------------------------------
>
> Key: YARN-10084
> URL: https://issues.apache.org/jira/browse/YARN-10084
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: capacity scheduler
> Affects Versions: 2.10.0, 3.2.1, 3.1.3
> Reporter: Eric Payne
> Assignee: Eric Payne
> Priority: Major
> Attachments: YARN-10084.001.patch
>
>
> Currently, {{maximum-application-lifetime}} and
> {{default-application-lifetime}} must be set for each leaf queue. If it is
> not set for a particular leaf queue, then there will be no time limit on apps
> running in that queue. It should be possible to set
> {{yarn.scheduler.capacity.root.maximum-application-lifetime}} for the root
> queue and allow child queues to override that value if desired.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
