[ 
https://issues.apache.org/jira/browse/YARN-584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13817871#comment-13817871
 ] 

Harshit Daga commented on YARN-584:
-----------------------------------

1. Sandy logic is same for both the schedulers , will add a new class as you 
suggested to prevent code duplication.

One question can't we put this in some already existing common class ? If you 
know let me know else will try to find, if not able to get any class with such 
common usage then will go on with adding SchedulerPageUtil class.
  
With respect to coding pattern will do the changes and update the patch.

2. Steps taken to manually verify patch
       1. Tested the patch on my machine with queues and sub queues 
        example : 
        a. root -> [root.queue1 and root.queue2]
        b. root->[ root.queue1->[root.queue1.queuea , root.queue1.queueb] and 
root.queue2]

       Test Cases
        i. First time page is loading properly : success.
        ii. Open (Expand) a queue and reload the page , the queue that was 
opened earlier should be open after page is reloaded : success.
        iii. Expand (Open) and Unexpand (Close) few queue's and reload the page 
again, the queue which were unexpanded before page reload should be unexpanded 
even after reload and the one which were in expanded state should be in 
expanded state ie. page should look the same even after reload with respect to 
queues open/close state. : success.

        Tested in chrome (version 30.0.1599.101), Safari(Version 6.1 (7537.71)) 
and Firefox(version 20.0)
        System : Mac OS X (version 10.7.5)

3. For "The patch appears to cause the build to fail." 
I added my patch to checked out trunk using patch -p0 < 
YARN-584-branch-2.2.0.patch ( at root folder )
and then build it using  mvn install -DskipTests  and I got a  BUILD SUCCESS 
can you why log is showing build fail ?


> In fair scheduler web UI, queues unexpand on refresh
> ----------------------------------------------------
>
>                 Key: YARN-584
>                 URL: https://issues.apache.org/jira/browse/YARN-584
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: scheduler
>    Affects Versions: 2.0.3-alpha
>            Reporter: Sandy Ryza
>              Labels: newbie
>         Attachments: YARN-584-branch-2.2.0.patch
>
>
> In the fair scheduler web UI, you can expand queue information.  Refreshing 
> the page causes the expansions to go away, which is annoying for someone who 
> wants to monitor the scheduler page and needs to reopen all the queues they 
> care about each time.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to