[ 
https://issues.apache.org/jira/browse/YARN-584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13821712#comment-13821712
 ] 

Harshit Daga commented on YARN-584:
-----------------------------------

bq. Also, maybe rename them to ExpandQueueNode and StoreExpandedQueueNode to 
make it clear what they deal with?

Can you please suggest some other name as \\
- ExpandNode / reopenNodes  : means after render nodes which were earlier in 
expanded state will be expanded again.
- StoreExpandedQueueNode : means whenever user is opening a node store that 
node ( in this case as url param ), for later usage ie. when page is reloaded.

bq. I don't think we to place ExpandNode and StoreExpandedNode into their own 
inner class - we can put them directly in SchedulerPageUtil. 
Removed the inner class and made them as methods. \\

1. Added space before open curly brace where ever it is present. \\
2. Indented the code the way you asked and using already present class as 
reference. \\

{{Will upload the updated patch once we finalize the method name}}. 

> In fair scheduler web UI, queues unexpand on refresh
> ----------------------------------------------------
>
>                 Key: YARN-584
>                 URL: https://issues.apache.org/jira/browse/YARN-584
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: scheduler
>    Affects Versions: 2.0.3-alpha
>            Reporter: Sandy Ryza
>              Labels: newbie
>         Attachments: YARN-584-branch-2.2.0.patch, 
> YARN-584-branch-2.2.0.patch, YARN-584-branch-2.2.0.patch, 
> YARN-584-branch-2.2.0.patch
>
>
> In the fair scheduler web UI, you can expand queue information.  Refreshing 
> the page causes the expansions to go away, which is annoying for someone who 
> wants to monitor the scheduler page and needs to reopen all the queues they 
> care about each time.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to