[
https://issues.apache.org/jira/browse/YARN-584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13819783#comment-13819783
]
Sandy Ryza commented on YARN-584:
---------------------------------
The patch is getting closer. A few more comments:
I don't think we to place ExpandNode and StoreExpandedNode into their own inner
class - we can put them directly in SchedulerPageUtil. Also, maybe rename them
to ExpandQueueNode and StoreExpandedQueueNode to make it clear what they deal
with?
{code}
+ static class ExpandNode extends HtmlBlock{
{code}
Some unnecessary trailing spaces on this line.
{code}
+public class SchedulerPageUtil{
{code}
A space is expected before the curly brace. This applies to a few other places
in the patch as well.
{code}
+ protected void render(Block html) {
+ html.
+ script().$type("text/javascript").
+ _("function reopenQueryNodes(){",
{code}
{code}
+ " });",
+ "}")._();
+ }
+
+ }
{code}
Fix indentation.
> In fair scheduler web UI, queues unexpand on refresh
> ----------------------------------------------------
>
> Key: YARN-584
> URL: https://issues.apache.org/jira/browse/YARN-584
> Project: Hadoop YARN
> Issue Type: Bug
> Components: scheduler
> Affects Versions: 2.0.3-alpha
> Reporter: Sandy Ryza
> Labels: newbie
> Attachments: YARN-584-branch-2.2.0.patch,
> YARN-584-branch-2.2.0.patch, YARN-584-branch-2.2.0.patch,
> YARN-584-branch-2.2.0.patch
>
>
> In the fair scheduler web UI, you can expand queue information. Refreshing
> the page causes the expansions to go away, which is annoying for someone who
> wants to monitor the scheduler page and needs to reopen all the queues they
> care about each time.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
