[
https://issues.apache.org/jira/browse/YARN-1028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13844747#comment-13844747
]
Xuan Gong commented on YARN-1028:
---------------------------------
small nit :
Add
{code}
getRMAdminService(0).transitionToActive(req);
getRMAdminService(1).transitionToStandBy(req);
{code}
To
{code}
+ @Test
+ public void testExplicitFailover()
+ throws YarnException, InterruptedException, IOException {
+ verifyNodeManagerConnected();
+ verifyClientConnection();
+
+ // Failover to the second RM
+ getRMAdminService(0).transitionToStandby(req);
+ getRMAdminService(1).transitionToActive(req);
+
+ verifyNodeManagerConnected();
+ verifyClientConnection();
+
+ // Failover back to the first RM
+ verifyNodeManagerConnected();
+ verifyClientConnection();
+ }
{code}
to failover back to first RM.
Others are LGTM
> Add FailoverProxyProvider like capability to RMProxy
> ----------------------------------------------------
>
> Key: YARN-1028
> URL: https://issues.apache.org/jira/browse/YARN-1028
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Bikas Saha
> Assignee: Karthik Kambatla
> Attachments: yarn-1028-1.patch, yarn-1028-2.patch, yarn-1028-3.patch,
> yarn-1028-4.patch, yarn-1028-5.patch, yarn-1028-draft-cumulative.patch
>
>
> RMProxy layer currently abstracts RM discovery and implements it by looking
> up service information from configuration. Motivated by HDFS and using
> existing classes from Common, we can add failover proxy providers that may
> provide RM discovery in extensible ways.
--
This message was sent by Atlassian JIRA
(v6.1.4#6159)
