[
https://issues.apache.org/jira/browse/YARN-1028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13846315#comment-13846315
]
Karthik Kambatla commented on YARN-1028:
----------------------------------------
Thanks Tom. Updated the patch to address your comments.
bq. It looks like the behaviour in this patch differs from the way failover is
implemented for HDFS HA, where it is controlled by dfs.client.failover settings
For consistency, all yarn-failover configs are prefixed by
yarn.client.failover. The suffixes are also similar to the ones HDFS uses, but
use hyphens instead of dots for consistency with rest of YARN configs.
bq. Why do you need both YarnFailoverProxyProvider and
ConfiguredFailoverProxyProvider?
Changed {{YarnFailoverProxyProvider}} to an interface with a single method
{{#init(Conf, RMProxy, Class<T> protocol)}}. This init() is called after
creating an instance of the specified class. HDFS, on the other hand, expects
the plugged-in FailoverProxyProvider to have a constructor of a particular
form. I think the approach in the current patch is cleaner, so anyone writing a
plugin knows they should have an init method. What do you think? I can change
it to remove YarnFailoverProxyProvider altogether if you think it is a better
approach.
> Add FailoverProxyProvider like capability to RMProxy
> ----------------------------------------------------
>
> Key: YARN-1028
> URL: https://issues.apache.org/jira/browse/YARN-1028
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Bikas Saha
> Assignee: Karthik Kambatla
> Attachments: yarn-1028-1.patch, yarn-1028-2.patch, yarn-1028-3.patch,
> yarn-1028-4.patch, yarn-1028-5.patch, yarn-1028-6.patch,
> yarn-1028-draft-cumulative.patch
>
>
> RMProxy layer currently abstracts RM discovery and implements it by looking
> up service information from configuration. Motivated by HDFS and using
> existing classes from Common, we can add failover proxy providers that may
> provide RM discovery in extensible ways.
--
This message was sent by Atlassian JIRA
(v6.1.4#6159)
