[
https://issues.apache.org/jira/browse/YARN-1028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13846395#comment-13846395
]
Tom White commented on YARN-1028:
---------------------------------
Thanks for the explanation of how failover works, Karthik. I think the failover
configuration is much better now - the patch is very close. Just a few minor
comments:
* The YarnFailoverProxyProvider interface is an improvement. It might be good
to have "RM" in its name since it is about RM failover. Ditto for
ConfiguredFailoverProxyProvider.
* It would be nice to have YarnClientImpl still report which RM it submitted to
- the logical name when HA is enabled, the host/port when not.
* Nit: TestRMFailover has a spurious log message LOG.error("KK")
* Nit: YARN_MINI_CLUSTER_USE_RPC and DEFAULT_YARN_MINI_CLUSTER_USE_RPC - should
be "MINICLUSTER" (without a space) for consistency with existing names.
> Add FailoverProxyProvider like capability to RMProxy
> ----------------------------------------------------
>
> Key: YARN-1028
> URL: https://issues.apache.org/jira/browse/YARN-1028
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Bikas Saha
> Assignee: Karthik Kambatla
> Attachments: yarn-1028-1.patch, yarn-1028-2.patch, yarn-1028-3.patch,
> yarn-1028-4.patch, yarn-1028-5.patch, yarn-1028-6.patch,
> yarn-1028-draft-cumulative.patch
>
>
> RMProxy layer currently abstracts RM discovery and implements it by looking
> up service information from configuration. Motivated by HDFS and using
> existing classes from Common, we can add failover proxy providers that may
> provide RM discovery in extensible ways.
--
This message was sent by Atlassian JIRA
(v6.1.4#6159)
