[ https://issues.apache.org/jira/browse/YARN-1413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13852365#comment-13852365 ]
Mayank Bansal commented on YARN-1413: ------------------------------------- Thanks [~vinodkv] and [~zjshen] for review bq. 1. The wrong javadoc bellow: Done bq. 2. I think the better way to construct the logURL in attempt/container blocks is to use ContainerReport.getLogURL directly (adding host:port prefix), instead of combining several attributes. The logURL should be set correctly in RMContainer final transition. Done bq. Does it make sense to add some kind of a util method in ContainerLogsUtils and use it everywhere? There are far too many places that are manually constructing these log URLs. Done Thanks, Mayank > [YARN-321] AHS WebUI should server aggregated logs as well > ---------------------------------------------------------- > > Key: YARN-1413 > URL: https://issues.apache.org/jira/browse/YARN-1413 > Project: Hadoop YARN > Issue Type: Sub-task > Reporter: Zhijie Shen > Assignee: Mayank Bansal > Attachments: YARN-1413-1.patch > > -- This message was sent by Atlassian JIRA (v6.1.4#6159)