[
https://issues.apache.org/jira/browse/YARN-1413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13852527#comment-13852527
]
Zhijie Shen commented on YARN-1413:
-----------------------------------
Thanks for the patch, Mayank! It's almost fine. Just some minor comments:
1. Change "Log" -> "Logs", and should we take care of the case that LogUrl
doesn't exist?
{code}
- _("Logs:", container.getLogUrl() == null ?
- "#" : root_url(container.getLogUrl()), container.getLogUrl()).
+ _("Logs:",url(logURL), "Log").
{code}
2. Would you please add some test cases in TestAHSWebApp for the aggregated
logs page? You can refer to the other test cases in TestAHSWebApp and
TestHSWebApp.
3. It seems that the logURL construction logic is added in ContainerLogsUtils.
And rationale here?
bq. Does it make sense to add some kind of a util method in ContainerLogsUtils
and use it everywhere? There are far too many places that are manually
constructing these log URLs.
bq. Done
BTW, it is tested locally that the aggregated logs page display correctly,
right?
> [YARN-321] AHS WebUI should server aggregated logs as well
> ----------------------------------------------------------
>
> Key: YARN-1413
> URL: https://issues.apache.org/jira/browse/YARN-1413
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Zhijie Shen
> Assignee: Mayank Bansal
> Attachments: YARN-1413-1.patch, YARN-1413-2.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.1.4#6159)
