[
https://issues.apache.org/jira/browse/YARN-1413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13853066#comment-13853066
]
Zhijie Shen commented on YARN-1413:
-----------------------------------
bq. I am not sure what you are asking here , I think I am only doing it once at
RMContainerImpl
If I remember correctly, the similar way of constructing the url to the logs is
used elsewhere. That's why [~vinodkv] suggested doing once in
ContainerLogsUtils and being called everywhere.
If the web root path is removed, I think we should remove
HttpConfig.getSchemePrefix() as well, which will be decided by the AHS web
server as well. Or [~vinodkv], do you have better idea about constructing the
logURL?
{code}
+ container.logURL = join(HttpConfig.getSchemePrefix(), "/logs", "/",
{code}
bq. We are using AgreegatedLogs and its test already so not sure we will add
any value.
JHS has the page wraps the aggregatedlogsblock, so it adds the test to see the
web page is rendered correct. That's why I'm thinking AHS should do the same,
though aggregatedlogsblock itself is evaluated. However, since the patch is
tested locally, and if you're confident about it, I'm fine with not having the
test.
> [YARN-321] AHS WebUI should server aggregated logs as well
> ----------------------------------------------------------
>
> Key: YARN-1413
> URL: https://issues.apache.org/jira/browse/YARN-1413
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Zhijie Shen
> Assignee: Mayank Bansal
> Attachments: YARN-1413-1.patch, YARN-1413-2.patch, YARN-1413-3.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.1.4#6159)
