[
https://issues.apache.org/jira/browse/YARN-1730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13913654#comment-13913654
]
Zhijie Shen commented on YARN-1730:
-----------------------------------
Some nits:
1. TIMELINE_SERVICE_LEVELDB_START_TIME_READ_CACHE ->
TIMELINE_SERVICE_LEVELDB_START_TIME_READ_CACHE_SIZE, and start-time-read-cache
-> start-time-read-cache-size?
2. Move the constant to YarnConfiguration, and rename it properly
{code}
+ private static final int DEFAULT_START_TIME_READ_CACHE_SIZE = 10000;
+ private static final int DEFAULT_START_TIME_WRITE_CACHE_SIZE = 10000;
{code}
3. Default configs need to be in yarn-default.xml as well
> Leveldb timeline store needs simple write locking
> -------------------------------------------------
>
> Key: YARN-1730
> URL: https://issues.apache.org/jira/browse/YARN-1730
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Billie Rinaldi
> Assignee: Billie Rinaldi
> Attachments: YARN-1730.1.patch, YARN-1730.2.patch, YARN-1730.3.patch,
> YARN-1730.4.patch, YARN-1730.5.patch
>
>
> The actual data writes are performed atomically in a batch, but a lock should
> be held while identifying a start time for the entity, which precedes every
> write.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
