[ 
https://issues.apache.org/jira/browse/YARN-1730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13919661#comment-13919661
 ] 

Vinod Kumar Vavilapalli commented on YARN-1730:
-----------------------------------------------

I wish there were more tests, but testing these write locks isn't easy. So I am 
fine for now.

The latest patch looks good to me. +1. Checking this in.

> Leveldb timeline store needs simple write locking
> -------------------------------------------------
>
>                 Key: YARN-1730
>                 URL: https://issues.apache.org/jira/browse/YARN-1730
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Billie Rinaldi
>            Assignee: Billie Rinaldi
>         Attachments: YARN-1730.1.patch, YARN-1730.2.patch, YARN-1730.3.patch, 
> YARN-1730.4.patch, YARN-1730.5.patch, YARN-1730.6.patch
>
>
> Although the leveldb writes are performed atomically in a batch, a start time 
> for the entity needs to identified before each write.  Thus a per-entity 
> write lock should be acquired.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to