[
https://issues.apache.org/jira/browse/YARN-1730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13913739#comment-13913739
]
Vinod Kumar Vavilapalli commented on YARN-1730:
-----------------------------------------------
More comments
- Similar to above renames, rename {{getRead|WriteCacheSize()}} APIs to
include the key-word "start-time"?
- Create a prefix constant for "*.leveldb-timeline-store" in YarnConfiguration.
- Why do we need separate start-time caches for read and write calls?
- Shouldn't we do the write-locking at the {{put(..)}} API level itself and
not just creating the start-time? Or at-least when the actual write happens for
a given entity?
- Not sure if we should make these cache-sizes public and document in
yarn-default.xml. They seem like internal only configs that nobody should touch
in normal situations. Right?
> Leveldb timeline store needs simple write locking
> -------------------------------------------------
>
> Key: YARN-1730
> URL: https://issues.apache.org/jira/browse/YARN-1730
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Billie Rinaldi
> Assignee: Billie Rinaldi
> Attachments: YARN-1730.1.patch, YARN-1730.2.patch, YARN-1730.3.patch,
> YARN-1730.4.patch, YARN-1730.5.patch
>
>
> The actual data writes are performed atomically in a batch, but a lock should
> be held while identifying a start time for the entity, which precedes every
> write.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
