[
https://issues.apache.org/jira/browse/YARN-1717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13923651#comment-13923651
]
Zhijie Shen commented on YARN-1717:
-----------------------------------
Hi Billie, thanks for patch. I've just a quick glance at it, which seems
generally fine. However, I've some questions:
1. How can users invoke the deletion operation? Should we provide some shell
script command?
2. Is it better to automatically discard the entities whose timestamp is older
than the configured timestamp? At lease, it could be an option other than
manually deleting the entities. Thoughts?
3. I'm a bit concerned of returning EntityWithReverseRelatedEntities from the
leveldb timeline store, because it will potentially change the output schema,
though the current code doesn't. However, it may involve additional effort in
the future to ensure the output schema will not be affected, when we make some
change in the leveldb timeline store. How about converting it back to Entity
before returning?
> Enable offline deletion of entries in leveldb timeline store
> ------------------------------------------------------------
>
> Key: YARN-1717
> URL: https://issues.apache.org/jira/browse/YARN-1717
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Billie Rinaldi
> Assignee: Billie Rinaldi
> Attachments: YARN-1717.1.patch, YARN-1717.2.patch, YARN-1717.3.patch,
> YARN-1717.4.patch, YARN-1717.5.patch, YARN-1717.6-extra.patch,
> YARN-1717.6.patch, YARN-1717.7.patch, YARN-1717.8.patch
>
>
> The leveldb timeline store implementation needs the following:
> * better documentation of its internal structures
> * internal changes to enable deleting entities
> ** never overwrite existing primary filter entries
> ** add hidden reverse pointers to related entities
--
This message was sent by Atlassian JIRA
(v6.2#6252)
