[
https://issues.apache.org/jira/browse/YARN-1931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13967224#comment-13967224
]
Sandy Ryza commented on YARN-1931:
----------------------------------
bq. It'll be great to also put a class level javadoc comment that this is
indeed private and that folks should not use it directly.
addToEnvironment environment and setEnvFromInputString are both used by
MapReduce. As there is no up-to-date developer documentation, the MapReduce
code is currently the best place to learn about how to build
ContainerLaunchContexts, so I think it would be good to make sure it showcases
the best practices for other YARN applications. Also, addToEnvironment is
marked Public. Would it make sense to mark the class Public and mark all
methods other than these two as Private?
> Private API change in YARN-1824 in 2.4 broke compatibility with previous
> releases
> ---------------------------------------------------------------------------------
>
> Key: YARN-1931
> URL: https://issues.apache.org/jira/browse/YARN-1931
> Project: Hadoop YARN
> Issue Type: Bug
> Components: applications
> Affects Versions: 2.4.0
> Reporter: Thomas Graves
> Assignee: Sandy Ryza
> Priority: Blocker
> Attachments: YARN-1931-1.patch, YARN-1931.patch
>
>
> YARN-1824 broke compatibility with previous 2.x releases by changes the API's
> in org.apache.hadoop.yarn.util.Apps.{setEnvFromInputString,addToEnvironment}
> The old api should be added back in.
> This affects any ApplicationMasters who were using this api. It also breaks
> previously built MapReduce libraries from working with the new Yarn release
> as MR uses this api.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
