[ 
https://issues.apache.org/jira/browse/YARN-1931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13970144#comment-13970144
 ] 

Vinod Kumar Vavilapalli commented on YARN-1931:
-----------------------------------------------

bq. We can add the methods back, but I also prefer that not marking it as 
Public.
+1. Let's just put in the method here, add javadoc like I requested above and 
do everything else in other JIRAs.

bq. If needed, we should at least craft a newly well-written util class also 
with a better naming like AppUtils instead of Apps which is unclear for other 
new people working on YARN.
+1. And may be a better name than Apps or AppUtils :) But definitely another 
JIRA.

> Private API change in YARN-1824 in 2.4 broke compatibility with previous 
> releases
> ---------------------------------------------------------------------------------
>
>                 Key: YARN-1931
>                 URL: https://issues.apache.org/jira/browse/YARN-1931
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: applications
>    Affects Versions: 2.4.0
>            Reporter: Thomas Graves
>            Assignee: Sandy Ryza
>            Priority: Blocker
>         Attachments: YARN-1931-1.patch, YARN-1931.patch
>
>
> YARN-1824 broke compatibility with previous 2.x releases by changes the API's 
> in org.apache.hadoop.yarn.util.Apps.{setEnvFromInputString,addToEnvironment}  
> The old api should be added back in.
> This affects any ApplicationMasters who were using this api.  It also breaks 
> previously built MapReduce libraries from working with the new Yarn release 
> as MR uses this api. 



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to