[
https://issues.apache.org/jira/browse/YARN-2017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13996756#comment-13996756
]
Jian He commented on YARN-2017:
-------------------------------
Thanks Sandy, Wangda, and Tsuyoshi for the review and comments !
bq. Why take out the header comment in SchedulerNode?
accidentally removed, add it back.
bq. Can we use generics to avoid all the casting (and find bugs)?
makes sense. Changed the AbstractYarnScheduler to use generics.
we may need to change SchedulerNode to SchedulerNode<FSSchedulerApp> as well to
avoid the type cast warning. Changing that causes the patch much bigger as too
many references of SchedulerNode. we may fix it in a separate patch.
bq. I'm wondering if it is meaningful to merge this method, too much code
changes due to this merge.
this will be commonly used by YARN-1368, that's why I merge it here.
Fixed other comments accordingly.
> Merge some of the common lib code in schedulers
> -----------------------------------------------
>
> Key: YARN-2017
> URL: https://issues.apache.org/jira/browse/YARN-2017
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: resourcemanager
> Reporter: Jian He
> Assignee: Jian He
> Attachments: YARN-2017.1.patch, YARN-2017.2.patch
>
>
> A bunch of same code is repeated among schedulers, e.g: between
> FicaSchedulerNode and FSSchedulerNode. It's good to merge and share them in a
> common base.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
