[ 
https://issues.apache.org/jira/browse/YARN-2017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13995898#comment-13995898
 ] 

Sandy Ryza commented on YARN-2017:
----------------------------------

Thanks for working on this Jian.  A couple questions:

Why take out the header comment in SchedulerNode?

Can we use generics to avoid all the casting (and findbugs)?  I.e. "class 
CapacityScheduler extends AbstractYarnScheduler<FiCaSchedulerApp, 
FiCaSchedulerNode>"?

> Merge some of the common lib code in schedulers
> -----------------------------------------------
>
>                 Key: YARN-2017
>                 URL: https://issues.apache.org/jira/browse/YARN-2017
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>            Reporter: Jian He
>            Assignee: Jian He
>         Attachments: YARN-2017.1.patch
>
>
> A bunch of same code is repeated among schedulers, e.g:  between 
> FicaSchedulerNode and FSSchedulerNode. It's good to merge and share them in a 
> common base.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to