[
https://issues.apache.org/jira/browse/YARN-1569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14004034#comment-14004034
]
Vinod Kumar Vavilapalli commented on YARN-1569:
-----------------------------------------------
Let's not do this. If we are getting wrong events that are incorrectly getting
routed, I'd rather catch them at compile time instead of putting out a log that
nobody will look at. I propose we close this as WONT FIX.
> For handle(SchedulerEvent) in FifoScheduler and CapacityScheduler,
> SchedulerEvent should get checked (instanceof) for appropriate type before
> casting
> -----------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: YARN-1569
> URL: https://issues.apache.org/jira/browse/YARN-1569
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: scheduler
> Reporter: Junping Du
> Assignee: zhihai xu
> Priority: Minor
> Labels: newbie
> Attachments: yarn-1569.patch
>
>
> As following: http://wiki.apache.org/hadoop/CodeReviewChecklist, we should
> always check appropriate type before casting.
> handle(SchedulerEvent) in FifoScheduler and CapacityScheduler didn't check so
> far (no bug there now) but should be improved as FairScheduler.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
