[
https://issues.apache.org/jira/browse/YARN-1424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14025414#comment-14025414
]
Karthik Kambatla commented on YARN-1424:
----------------------------------------
Thanks Jason. I think it makes sense to keep it compatible.
bq. should I go back to using -1 as the invalid resource value?
Yes, thanks Ray. Sorry for the confusion. Now that we are going to keep it as
-1, we should probably document that in ApplicationUsageReport methods. That
way, at least, the users have a way to know they shouldn't blindly add -1 to
any statistics they compute.
> RMAppAttemptImpl should precompute a zeroed ApplicationResourceUsageReport to
> return when attempt not active
> ------------------------------------------------------------------------------------------------------------
>
> Key: YARN-1424
> URL: https://issues.apache.org/jira/browse/YARN-1424
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: resourcemanager
> Affects Versions: 2.4.0
> Reporter: Sandy Ryza
> Assignee: Ray Chiang
> Priority: Minor
> Labels: newbie
> Attachments: YARN1424-01.patch, YARN1424-02.patch
>
>
> RMAppImpl has a DUMMY_APPLICATION_RESOURCE_USAGE_REPORT to return when the
> caller of createAndGetApplicationReport doesn't have access.
> RMAppAttemptImpl should have something similar for
> getApplicationResourceUsageReport.
> It also might make sense to put the dummy report into
> ApplicationResourceUsageReport and allow both to use it.
> A test would also be useful to verify that
> RMAppAttemptImpl#getApplicationResourceUsageReport doesn't return null if the
> scheduler doesn't have a report to return.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
