[
https://issues.apache.org/jira/browse/YARN-1424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14025959#comment-14025959
]
Karthik Kambatla commented on YARN-1424:
----------------------------------------
Nits:
# TestClientRMService has a few lines over 80 chars.
# I would limit the documentation to say -1 for invalid/inaccessible reports.
{code}
/**
* Get the number of used containers. Returns -1 in the case of an invalid
* report or in the case where an error occurs fetching the report.
* @return the number of used containers
{code}
> RMAppAttemptImpl should precompute a zeroed ApplicationResourceUsageReport to
> return when attempt not active
> ------------------------------------------------------------------------------------------------------------
>
> Key: YARN-1424
> URL: https://issues.apache.org/jira/browse/YARN-1424
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: resourcemanager
> Affects Versions: 2.4.0
> Reporter: Sandy Ryza
> Assignee: Ray Chiang
> Priority: Minor
> Labels: newbie
> Attachments: YARN1424-01.patch, YARN1424-02.patch, YARN1424-03.patch
>
>
> RMAppImpl has a DUMMY_APPLICATION_RESOURCE_USAGE_REPORT to return when the
> caller of createAndGetApplicationReport doesn't have access.
> RMAppAttemptImpl should have something similar for
> getApplicationResourceUsageReport.
> It also might make sense to put the dummy report into
> ApplicationResourceUsageReport and allow both to use it.
> A test would also be useful to verify that
> RMAppAttemptImpl#getApplicationResourceUsageReport doesn't return null if the
> scheduler doesn't have a report to return.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
