[ https://issues.apache.org/jira/browse/YARN-1424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14025606#comment-14025606 ]
Ray Chiang commented on YARN-1424: ---------------------------------- [~vinodkv] Thanks. I'm still getting used to the processes in JIRA. The tests aren't missing as much as they were added on June 5th and I hadn't updated my local repository, so my patch was missing those updates. I'm working on a third patch attempt which should address all the comments (back to -1 for stats, update to the Javadoc comments of ApplicationResourceUsageReport, latest version of TestClientRMService, new unit test). Thanks for the comments everyone. I'm definitely "learning by doing". > RMAppAttemptImpl should precompute a zeroed ApplicationResourceUsageReport to > return when attempt not active > ------------------------------------------------------------------------------------------------------------ > > Key: YARN-1424 > URL: https://issues.apache.org/jira/browse/YARN-1424 > Project: Hadoop YARN > Issue Type: Improvement > Components: resourcemanager > Affects Versions: 2.4.0 > Reporter: Sandy Ryza > Assignee: Ray Chiang > Priority: Minor > Labels: newbie > Attachments: YARN1424-01.patch, YARN1424-02.patch > > > RMAppImpl has a DUMMY_APPLICATION_RESOURCE_USAGE_REPORT to return when the > caller of createAndGetApplicationReport doesn't have access. > RMAppAttemptImpl should have something similar for > getApplicationResourceUsageReport. > It also might make sense to put the dummy report into > ApplicationResourceUsageReport and allow both to use it. > A test would also be useful to verify that > RMAppAttemptImpl#getApplicationResourceUsageReport doesn't return null if the > scheduler doesn't have a report to return. -- This message was sent by Atlassian JIRA (v6.2#6252)