[ 
https://issues.apache.org/jira/browse/YARN-2354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14076439#comment-14076439
 ] 

Li Lu commented on YARN-2354:
-----------------------------

Same error message as YARN-2295, and could not reproduce locally. Seems like 
this is connected with the network settings of the server, causing the 
following lines to fail
{code}
      if (appReport.getHost().startsWith(hostName)
          && appReport.getRpcPort() == -1) {
        verified = true;
      }
{code}
If such check failed, verified will never be set to true, hence the test will 
fail. This failure appears to be unrelated to the problem fixed by this patch. 

> DistributedShell may allocate more containers than client specified after it 
> restarts
> -------------------------------------------------------------------------------------
>
>                 Key: YARN-2354
>                 URL: https://issues.apache.org/jira/browse/YARN-2354
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Jian He
>            Assignee: Li Lu
>         Attachments: YARN-2354-072514.patch
>
>
> To reproduce, run distributed shell with -num_containers option,
> In ApplicationMaster.java, the following code has some issue.
> {code}
>   int numTotalContainersToRequest =
>         numTotalContainers - previousAMRunningContainers.size();
>     for (int i = 0; i < numTotalContainersToRequest; ++i) {
>       ContainerRequest containerAsk = setupContainerAskForRM();
>       amRMClient.addContainerRequest(containerAsk);
>     }
>     numRequestedContainers.set(numTotalContainersToRequest);
> {code}
>  numRequestedContainers doesn't account for previous AM's requested 
> containers. so numRequestedContainers should be set to numTotalContainers



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to