[ 
https://issues.apache.org/jira/browse/YARN-2354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14079290#comment-14079290
 ] 

Hudson commented on YARN-2354:
------------------------------

FAILURE: Integrated in Hadoop-Hdfs-trunk #1821 (See 
[https://builds.apache.org/job/Hadoop-Hdfs-trunk/1821/])
YARN-2354. DistributedShell may allocate more containers than client specified 
after AM restarts. Contributed by Li Lu (jianhe: 
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1614538)
* /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt
* 
/hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/src/main/java/org/apache/hadoop/yarn/applications/distributedshell/ApplicationMaster.java
* 
/hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/src/test/java/org/apache/hadoop/yarn/applications/distributedshell/TestDSFailedAppMaster.java


> DistributedShell may allocate more containers than client specified after it 
> restarts
> -------------------------------------------------------------------------------------
>
>                 Key: YARN-2354
>                 URL: https://issues.apache.org/jira/browse/YARN-2354
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Jian He
>            Assignee: Li Lu
>             Fix For: 2.6.0
>
>         Attachments: YARN-2354-072514.patch, YARN-2354-072814.patch, 
> YARN-2354-072914.patch
>
>
> To reproduce, run distributed shell with -num_containers option,
> In ApplicationMaster.java, the following code has some issue.
> {code}
>   int numTotalContainersToRequest =
>         numTotalContainers - previousAMRunningContainers.size();
>     for (int i = 0; i < numTotalContainersToRequest; ++i) {
>       ContainerRequest containerAsk = setupContainerAskForRM();
>       amRMClient.addContainerRequest(containerAsk);
>     }
>     numRequestedContainers.set(numTotalContainersToRequest);
> {code}
>  numRequestedContainers doesn't account for previous AM's requested 
> containers. so numRequestedContainers should be set to numTotalContainers



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to