[
https://issues.apache.org/jira/browse/YARN-2056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14113124#comment-14113124
]
Wangda Tan commented on YARN-2056:
----------------------------------
Hi [~eepayne],
Really sorry to come late, thanks for working on this, I just took a look at
your method and patch, some comments:
1) I prefer to make per-queue disable preemption option follow the same config
options in existing capacity-scheduler (same queue-path-prefix, etc.).
2) {{mockNested}} when(q.getQueuePath()) should consider hierarchy of queue as
well
3) It's better to add tests for hierarchy of queues when preemption is disabled
4) In {{testPerQueueDisablePreemption}}, I think number of preemptions after
enable queue-b's preemption is not very clear to me:
{code}
+ // With no PREEMPTION_DISABLED set for queueB, get resources from both
+ // queueB and queueC (times() assertion is cumulative).
+ verify(mDisp, times(5)).handle(argThat(new IsPreemptionRequestFor(appB)));
+ verify(mDisp, times(16)).handle(argThat(new IsPreemptionRequestFor(appC)));
{code}
In the 2nd preemption, more resource reclaimed from appC than appB, I think it
should get resource from app more, could you please take a look at what
happened? I just afraid because we changed ideal resource calculation in 1st
preemption, is it possible to affect 2nd preemption?
Thanks,
Wangda
> Disable preemption at Queue level
> ---------------------------------
>
> Key: YARN-2056
> URL: https://issues.apache.org/jira/browse/YARN-2056
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: resourcemanager
> Affects Versions: 2.4.0
> Reporter: Mayank Bansal
> Assignee: Eric Payne
> Attachments: YARN-2056.201408202039.txt, YARN-2056.201408260128.txt
>
>
> We need to be able to disable preemption at individual queue level
--
This message was sent by Atlassian JIRA
(v6.2#6252)
