[
https://issues.apache.org/jira/browse/YARN-668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14148125#comment-14148125
]
Jian He commented on YARN-668:
------------------------------
- containerManagerImpl, TestApplicationMasterService changes revert
- default value of AMRMTokenIdentifier keyId. {{private int keyId =
Integer.MIN_VALUE;}}. Proto definition should have the same default
- following constructors may be not needed.
{code}
public NMTokenIdentifier(NMTokenIdentifierProto proto) {
this.proto = proto;
}
{code}
- why remove following ?
{code}
// LogAggregationContext is set as null
Assert.assertNull(getLogAggregationContextFromContainerToken(rm1, nm1,
null));
{code}
- remove the commented code
{code}
/* ByteArrayDataInput input = ByteStreams.newDataInput(
containerToken.getIdentifier().array());
ContainerTokenIdentifier containerTokenIdentifier =
new ContainerTokenIdentifier();
containerTokenIdentifier.readFields(input);*/
{code}
> TokenIdentifier serialization should consider Unknown fields
> ------------------------------------------------------------
>
> Key: YARN-668
> URL: https://issues.apache.org/jira/browse/YARN-668
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Siddharth Seth
> Assignee: Junping Du
> Priority: Blocker
> Attachments: YARN-668-demo.patch, YARN-668-v2.patch,
> YARN-668-v3.patch, YARN-668-v4.patch, YARN-668-v5.patch, YARN-668-v6.patch,
> YARN-668-v7.patch, YARN-668.patch
>
>
> This would allow changing of the TokenIdentifier between versions. The
> current serialization is Writable. A simple way to achieve this would be to
> have a Proto object as the payload for TokenIdentifiers, instead of
> individual fields.
> TokenIdentifier continues to implement Writable to work with the RPC layer -
> but the payload itself is serialized using PB.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
