Wangda Tan commented on YARN-2647:

Hi [~sunilg],
Thanks for the patch, some comments,

1) I think we should create a QueueCLI instead of putting it to ApplicationCLI 
-- it makes more sense to put attempts/containers into ApplicationCLI, they are 
all belongs to Application, but queue is not. 
I expect there will be some duplicated code between ApplicationCLI and 
QueueCLI, but shouldn't too much.

2) I think we don't need -listall, took a look at other commands, like 
application/container, -list is "list all", and -status will follow 
application-id or container-id. 
I think we can follow the same way: 
queue -list will list all queues, and 
queue -status <name or path> will print the specified queue only.

3) After rethink about your comment at: 
I actually think such filter like -show-acls or -show-nodelabels are make more 
sense when we need list all queues. For only one queue, print complete status 
should be acceptable.
I would suggest to remove the two options for now until someday people require 
for them, two reasons:
# The name "-show-acls" itself is ambigious, because we will show complete 
message by default, why only show acl after add the "-show-acls"? It should be 
"-show-acls-only". But if so, how to deal with when user put "-show-acls-only" 
and "show-nodelabels-only" together? 
# I expect there're more filter needed, such as "give me all information for 
queues under a parent queue" or "give me information for leaf queue only".

We can decide how to put filters better when such real requirements come. What 
you think?


> Add yarn queue CLI to get queue info including labels of such queue
> -------------------------------------------------------------------
>                 Key: YARN-2647
>                 URL: https://issues.apache.org/jira/browse/YARN-2647
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: client
>            Reporter: Wangda Tan
>            Assignee: Sunil G
>         Attachments: 0001-YARN-2647.patch

This message was sent by Atlassian JIRA

Reply via email to