[jira] [Commented] (YARN-2647) Add yarn queue CLI to get queue info including labels of such queue

[Wangda Tan (JIRA)]

    [ 
https://issues.apache.org/jira/browse/YARN-2647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14184147#comment-14184147
 ] 

Wangda Tan commented on YARN-2647:
----------------------------------

Some minor comments,

QueueCLI.java

1) 
bq. +    if (args.length > 0 && args[0].equalsIgnoreCase(QUEUE)) {
I think we can avoid such check, and should throw exception when it's not 
"queue", such as:\
{code}
if (args[0] != queue) {
        throw exception
}
// add options


2)
We don't need title, it should be hard coded to "queue" when print usage

Otherwise, looks good to me.

Thanks,
Wangda

> Add yarn queue CLI to get queue info including labels of such queue
> -------------------------------------------------------------------
>
>                 Key: YARN-2647
>                 URL: https://issues.apache.org/jira/browse/YARN-2647
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: client
>            Reporter: Wangda Tan
>            Assignee: Sunil G
>         Attachments: 0001-YARN-2647.patch, 0002-YARN-2647.patch, 
> 0003-YARN-2647.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)