[ 
https://issues.apache.org/jira/browse/YARN-2647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14184012#comment-14184012
 ] 

Wangda Tan commented on YARN-2647:
----------------------------------

[~sunilg],
Thanks for the update, some comments:
1) bq. +    if (args.length > 0 && args[0].equalsIgnoreCase(QUEUE)) {
I think the command should expect the args[0] is "queue", right? There should 
throw exception if it's not. 

With 1), I think such checks can be removed:
bq. !args[0].equalsIgnoreCase(QUEUE)

Tests and other parts looks good to me


> Add yarn queue CLI to get queue info including labels of such queue
> -------------------------------------------------------------------
>
>                 Key: YARN-2647
>                 URL: https://issues.apache.org/jira/browse/YARN-2647
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: client
>            Reporter: Wangda Tan
>            Assignee: Sunil G
>         Attachments: 0001-YARN-2647.patch, 0002-YARN-2647.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to