[
https://issues.apache.org/jira/browse/YARN-2825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14202422#comment-14202422
]
Jian He commented on YARN-2825:
-------------------------------
Thanks Jason for reviewing the patch !
bq. Or we could get the container status and check for COMPLETE which is what
other parts of the code are doing
the existing method is doing {{cloneAndGetContainerStatus}}, I just wanted to
avoid the clone part.
To conform with the rest of the code and also avoid doing the casting, I
exposed the getCurrentState in the interface, as I saw there's another caller
needs to do the same.
> Container leak on NM
> --------------------
>
> Key: YARN-2825
> URL: https://issues.apache.org/jira/browse/YARN-2825
> Project: Hadoop YARN
> Issue Type: Bug
> Reporter: Jian He
> Assignee: Jian He
> Priority: Critical
> Attachments: YARN-2825.1.patch, YARN-2825.1.patch
>
>
> Caused by YARN-1372. thanks [~vinodkv] for pointing this out.
> The problem is that in YARN-1372 we changed the behavior to remove containers
> from NMContext only after the containers are acknowledged by AM. But in the
> {{NodeStatusUpdaterImpl#removeCompletedContainersFromContext}} call, we
> didn't check whether the container is really completed or not. If the
> container is stilll running, we shouldn't remove the container from the
> context
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
