[
https://issues.apache.org/jira/browse/YARN-2825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14202530#comment-14202530
]
Jian He commented on YARN-2825:
-------------------------------
bq. what's the reasoning to avoid checking for the DONE state?
The only reason is to consistent with the check in
{{NodeStatusUpdaterImpl#getContainerStatuses}} where it's checking
ContainerState.COMPLETE rather than DONE. i can just change it check DONE
instead of adding a new method. updating the patch.
> Container leak on NM
> --------------------
>
> Key: YARN-2825
> URL: https://issues.apache.org/jira/browse/YARN-2825
> Project: Hadoop YARN
> Issue Type: Bug
> Reporter: Jian He
> Assignee: Jian He
> Priority: Critical
> Attachments: YARN-2825.1.patch, YARN-2825.1.patch, YARN-2825.2.patch
>
>
> Caused by YARN-1372. thanks [~vinodkv] for pointing this out.
> The problem is that in YARN-1372 we changed the behavior to remove containers
> from NMContext only after the containers are acknowledged by AM. But in the
> {{NodeStatusUpdaterImpl#removeCompletedContainersFromContext}} call, we
> didn't check whether the container is really completed or not. If the
> container is stilll running, we shouldn't remove the container from the
> context
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
