[ https://issues.apache.org/jira/browse/YARN-2825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14202765#comment-14202765 ]
Hadoop QA commented on YARN-2825: --------------------------------- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12680267/YARN-2825.3.patch against trunk revision 06b7979. {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 1 new or modified test files. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. There were no new javadoc warning messages. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 2.0.3) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:red}-1 core tests{color}. The patch failed these unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager: org.apache.hadoop.yarn.server.nodemanager.TestNodeStatusUpdater {color:green}+1 contrib tests{color}. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-YARN-Build/5792//testReport/ Console output: https://builds.apache.org/job/PreCommit-YARN-Build/5792//console This message is automatically generated. > Container leak on NM > -------------------- > > Key: YARN-2825 > URL: https://issues.apache.org/jira/browse/YARN-2825 > Project: Hadoop YARN > Issue Type: Bug > Reporter: Jian He > Assignee: Jian He > Priority: Critical > Attachments: YARN-2825.1.patch, YARN-2825.1.patch, YARN-2825.2.patch, > YARN-2825.3.patch > > > Caused by YARN-1372. thanks [~vinodkv] for pointing this out. > The problem is that in YARN-1372 we changed the behavior to remove containers > from NMContext only after the containers are acknowledged by AM. But in the > {{NodeStatusUpdaterImpl#removeCompletedContainersFromContext}} call, we > didn't check whether the container is really completed or not. If the > container is stilll running, we shouldn't remove the container from the > context -- This message was sent by Atlassian JIRA (v6.3.4#6332)