[ 
https://issues.apache.org/jira/browse/YARN-2675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14213107#comment-14213107
 ] 

Anubhav Dhoot commented on YARN-2675:
-------------------------------------

Minor: In ContainerImpl finished, it may be good to add a default case for 
which we log an error saying "unexpected state encountered, metrics may not be 
updated correctly" to catch issues like this in future
Otherwise LGTM.

> the containersKilled metrics is not updated when the container is killed 
> during localization.
> ---------------------------------------------------------------------------------------------
>
>                 Key: YARN-2675
>                 URL: https://issues.apache.org/jira/browse/YARN-2675
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: nodemanager
>    Affects Versions: 2.5.0
>            Reporter: zhihai xu
>            Assignee: zhihai xu
>         Attachments: YARN-2675.000.patch, YARN-2675.001.patch
>
>
> The containersKilled metrics is not updated when the container is killed 
> during localization. We should add KILLING state in finished of 
> ContainerImpl.java to update killedContainer.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to