[
https://issues.apache.org/jira/browse/YARN-2675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14213761#comment-14213761
]
Vinod Kumar Vavilapalli commented on YARN-2675:
-----------------------------------------------
I admit it's not caused by your patch, but the fact that we have to catch
'default' and log error without any action tells me this is broken.
I think we should dismantle the finished() method altogether and directly have
separate transitions which sub-class ContainerDoneTransition and do the right
thing w.r.t metrics for that specific transition. Can we do that here?
> the containersKilled metrics is not updated when the container is killed
> during localization.
> ---------------------------------------------------------------------------------------------
>
> Key: YARN-2675
> URL: https://issues.apache.org/jira/browse/YARN-2675
> Project: Hadoop YARN
> Issue Type: Bug
> Components: nodemanager
> Affects Versions: 2.5.0
> Reporter: zhihai xu
> Assignee: zhihai xu
> Attachments: YARN-2675.000.patch, YARN-2675.001.patch,
> YARN-2675.002.patch
>
>
> The containersKilled metrics is not updated when the container is killed
> during localization. We should add KILLING state in finished of
> ContainerImpl.java to update killedContainer.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
