[
https://issues.apache.org/jira/browse/YARN-2868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14274252#comment-14274252
]
Wangda Tan commented on YARN-2868:
----------------------------------
Some comments:
1. It seems overkill to me to use AtomicLong to ensure allocation request sent
time will only be set once -- implementation of scheduler should make sure
that. If lock-free access is required, use volatile is enough.
2. Rename {{allocationRequestStart}} to
{{amContainerAllocationRequestSentTime}}?
3. It's not necessary to track first AM-container allocation in
SchedulerApplicationAttempt. When scheduler knows AM container allocated, it
should use AM-Container.getCreationTime() and amAllocationRequestSent time to
get the delay.
> Add metric for initial container launch time
> --------------------------------------------
>
> Key: YARN-2868
> URL: https://issues.apache.org/jira/browse/YARN-2868
> Project: Hadoop YARN
> Issue Type: Improvement
> Reporter: Ray Chiang
> Assignee: Ray Chiang
> Labels: metrics, supportability
> Attachments: YARN-2868-01.patch, YARN-2868.002.patch,
> YARN-2868.003.patch, YARN-2868.004.patch, YARN-2868.005.patch
>
>
> Add a metric to measure the latency between "starting container allocation"
> and "first container actually allocated".
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
