[ 
https://issues.apache.org/jira/browse/YARN-2868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14285424#comment-14285424
 ] 

Rohith commented on YARN-2868:
------------------------------

Thanks [~rchiang] for working on this jira.
Some commets and doubts
Doubts : 
# From the patch I see this metric added only for FairScheduler. I believe this 
metric can be added for all the schedulers. Is there any specific reason for 
not adding for CS?
# I believe this metric is specific to application makes more value add. Adding 
into scheduler level, what is the benifit users getting from this since this 
value wil be always shown only for last application?

Comments :
# In the below code, variable initialized is unused. If not rquired, this can 
be removed.
{code}
    synchronized (application) {
      boolean initialized = 
application.trySetFirstAllocationRequestSentTime(start);
    }
{code}
# timediff is added for both rootMetrics and queueMetrics. So both queueMetric 
contrains same value.By definition of {{rootMetrics}}, it cotaines aggregated 
value for schedulers and queuMetrics contains only specific to queue level.
Any thought on this?
{code}  
 if (timediff>0) {
            rootMetrics.addContainerFirstAttemptAllocationDelay(timediff);
          }
          RMApp rmApp = 
rmContext.getRMApps().get(appAttemptId.getApplicationId());
          if (rmApp!=null) {
            String metricsQueue = rmApp.getQueue();
            if (metricsQueue!=null) {
              FSQueue queue = queueMgr.getQueue(metricsQueue);
              
queue.getMetrics().addContainerFirstAttemptAllocationDelay(timediff);
            }
          }
{code}


> Add metric for initial container launch time
> --------------------------------------------
>
>                 Key: YARN-2868
>                 URL: https://issues.apache.org/jira/browse/YARN-2868
>             Project: Hadoop YARN
>          Issue Type: Improvement
>            Reporter: Ray Chiang
>            Assignee: Ray Chiang
>              Labels: metrics, supportability
>         Attachments: YARN-2868-01.patch, YARN-2868.002.patch, 
> YARN-2868.003.patch, YARN-2868.004.patch, YARN-2868.005.patch, 
> YARN-2868.006.patch
>
>
> Add a metric to measure the latency between "starting container allocation" 
> and "first container actually allocated".



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to