[ 
https://issues.apache.org/jira/browse/YARN-3079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14290042#comment-14290042
 ] 

Anubhav Dhoot commented on YARN-3079:
-------------------------------------

Should we add a couple of more combinations to the test to ensure coverage?
Update node2 where it increases resources but the increase is less than current 
max and see no change 
Update node2 where it decreases resources but the original and new are both 
less than the current max and see no change?

> Scheduler should also update maximumAllocation when updateNodeResource.
> -----------------------------------------------------------------------
>
>                 Key: YARN-3079
>                 URL: https://issues.apache.org/jira/browse/YARN-3079
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: zhihai xu
>            Assignee: zhihai xu
>         Attachments: YARN-3079.000.patch, YARN-3079.001.patch
>
>
> Scheduler should also update maximumAllocation when updateNodeResource. 
> Otherwise even the node resource is changed by 
> AdminService#updateNodeResource, maximumAllocation won't be changed.
> Also RMNodeReconnectEvent called from 
> ResourceTrackerService#registerNodeManager will also trigger 
> AbstractYarnScheduler#updateNodeResource being called.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to