zhihai xu commented on YARN-3079:

thanks [~rchiang] and [~leftnoteasy]'s review.
bq. IMHO, I think they're exchangeable, update a node = remove then a
Yes, It make sense to keep code clean, since the node will only disappear for a 
very short time. AbstractYarnScheduler#getMaximumResourceCapability will be 
called in this period very rarely. Even it happen, the side effect will be very 
The upload a new patch YARN-3079.003.patch which addressed [~leftnoteasy]'s 

> Scheduler should also update maximumAllocation when updateNodeResource.
> -----------------------------------------------------------------------
>                 Key: YARN-3079
>                 URL: https://issues.apache.org/jira/browse/YARN-3079
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: zhihai xu
>            Assignee: zhihai xu
>         Attachments: YARN-3079.000.patch, YARN-3079.001.patch, 
> YARN-3079.002.patch, YARN-3079.003.patch
> Scheduler should also update maximumAllocation when updateNodeResource. 
> Otherwise even the node resource is changed by 
> AdminService#updateNodeResource, maximumAllocation won't be changed.
> Also RMNodeReconnectEvent called from 
> ResourceTrackerService#registerNodeManager will also trigger 
> AbstractYarnScheduler#updateNodeResource being called.

This message was sent by Atlassian JIRA

Reply via email to