[
https://issues.apache.org/jira/browse/YARN-3079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14296077#comment-14296077
]
zhihai xu commented on YARN-3079:
---------------------------------
Hi [~rkanter], thanks for the review. I found out since we can reuse the
updateMaximumAllocation in updateNodeResource, we don't need create a separate
function refreshMaximumAllocation. So I removed refreshMaximumAllocation and
move all the code in refreshMaximumAllocation to updateMaximumAllocation which
is the same as the original code. The change will also address your concern.
Please review it to see whether it looks good to you.
thanks zhihai
> Scheduler should also update maximumAllocation when updateNodeResource.
> -----------------------------------------------------------------------
>
> Key: YARN-3079
> URL: https://issues.apache.org/jira/browse/YARN-3079
> Project: Hadoop YARN
> Issue Type: Bug
> Reporter: zhihai xu
> Assignee: zhihai xu
> Attachments: YARN-3079.000.patch, YARN-3079.001.patch,
> YARN-3079.002.patch, YARN-3079.003.patch, YARN-3079.004.patch
>
>
> Scheduler should also update maximumAllocation when updateNodeResource.
> Otherwise even the node resource is changed by
> AdminService#updateNodeResource, maximumAllocation won't be changed.
> Also RMNodeReconnectEvent called from
> ResourceTrackerService#registerNodeManager will also trigger
> AbstractYarnScheduler#updateNodeResource being called.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
