[ https://issues.apache.org/jira/browse/YARN-2799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14322690#comment-14322690 ]
Hadoop QA commented on YARN-2799: --------------------------------- {color:green}+1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12698939/YARN-2799.002.patch against trunk revision ab0b958. {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 1 new or modified test files. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. There were no new javadoc warning messages. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 2.0.3) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 core tests{color}. The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager. Test results: https://builds.apache.org/job/PreCommit-YARN-Build/6642//testReport/ Console output: https://builds.apache.org/job/PreCommit-YARN-Build/6642//console This message is automatically generated. > cleanup TestLogAggregationService based on the change in YARN-90 > ---------------------------------------------------------------- > > Key: YARN-2799 > URL: https://issues.apache.org/jira/browse/YARN-2799 > Project: Hadoop YARN > Issue Type: Improvement > Components: test > Reporter: zhihai xu > Assignee: zhihai xu > Priority: Minor > Attachments: YARN-2799.000.patch, YARN-2799.001.patch, > YARN-2799.002.patch > > > cleanup TestLogAggregationService based on the change in YARN-90. > The following code is added to setup in YARN-90, > {code} > dispatcher = createDispatcher(); > appEventHandler = mock(EventHandler.class); > dispatcher.register(ApplicationEventType.class, appEventHandler); > {code} > In this case, we should remove all these code from each test function to > avoid duplicate code. > Same for dispatcher.stop() which is in tearDown, > we can remove dispatcher.stop() from from each test function also because it > will always be called from tearDown for each test. -- This message was sent by Atlassian JIRA (v6.3.4#6332)