[
https://issues.apache.org/jira/browse/YARN-3222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14345513#comment-14345513
]
Jian He commented on YARN-3222:
-------------------------------
thanks Rohith !
I think the condition check you added earlier about sending NodeResourceUpdate
event only if the node resource is different is useful, that saves some
traffic. would you mind adding that too ?
{code}
if (rmNode.getState().equals(NodeState.RUNNING)) {
// Update scheduler node's capacity for reconnect node.
rmNode.context
.getDispatcher()
.getEventHandler()
.handle(
new NodeResourceUpdateSchedulerEvent(rmNode, ResourceOption
.newInstance(newNode.getTotalCapability(), -1)));
}
{code}
> RMNodeImpl#ReconnectNodeTransition should send scheduler events in sequential
> order
> -----------------------------------------------------------------------------------
>
> Key: YARN-3222
> URL: https://issues.apache.org/jira/browse/YARN-3222
> Project: Hadoop YARN
> Issue Type: Bug
> Components: resourcemanager
> Affects Versions: 2.6.0
> Reporter: Rohith
> Assignee: Rohith
> Priority: Critical
> Attachments: 0001-YARN-3222.patch, 0002-YARN-3222.patch,
> 0003-YARN-3222.patch, 0004-YARN-3222.patch
>
>
> When a node is reconnected,RMNodeImpl#ReconnectNodeTransition notifies the
> scheduler in a events node_added,node_removed or node_resource_update. These
> events should be notified in an sequential order i.e node_added event and
> next node_resource_update events.
> But if the node is reconnected with different http port, the oder of
> scheduler events are node_removed --> node_resource_update --> node_added
> which causes scheduler does not find the node and throw NPE and RM exit.
> Node_Resource_update event should be always should be triggered via
> RMNodeEventType.RESOURCE_UPDATE
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
