Zhijie Shen commented on YARN-3034:

Some comments about the patch:

an incompatible change.

2. RMTimelineCollector doesn't need to be exposed to RM and it's context. It 
seems to be enough to construct it inside SystemMetricsPublisher only.

bq. I would prefer for the former one as it would be simpler to review. Please 
provide your opinion

I filed a separate Jira: YARN-3390

> [Collector wireup] Implement RM starting its timeline collector
> ---------------------------------------------------------------
>                 Key: YARN-3034
>                 URL: https://issues.apache.org/jira/browse/YARN-3034
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>            Reporter: Sangjin Lee
>            Assignee: Naganarasimha G R
>         Attachments: YARN-3034-20150312-1.patch, YARN-3034.20150205-1.patch, 
> YARN-3034.20150316-1.patch, YARN-3034.20150318-1.patch, 
> YARN-3034.20150320-1.patch
> Per design in YARN-2928, implement resource managers starting their own ATS 
> writers.

This message was sent by Atlassian JIRA

Reply via email to