[ 
https://issues.apache.org/jira/browse/YARN-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14376349#comment-14376349
 ] 

Naganarasimha G R commented on YARN-3034:
-----------------------------------------

Thanks for your comments [~zjshen]
bq. RM_SYSTEM_METRICS_PUBLISHER_ENABLED -> SYSTEM_METRICS_PUBLISHER_ENABLED is 
an incompatible change. :
This i incorporated based on [~vinodkv]'s 
[comment|https://issues.apache.org/jira/browse/YARN-3034?focusedCommentId=14360797&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14360797],
 And also i have added old keys as part of {{addDeprecatedKeys}}, so i think 
its not an incompatible change. Please provide your opinion on the same.

bq. RMTimelineCollector doesn't need to be exposed to RM and it's context. It 
seems to be enough to construct it inside SystemMetricsPublisher only.
IIUC  SystemMetricsPublisher.publish*Event methods can determine which version 
of ATS to publish and can post it accordingly ?

> [Collector wireup] Implement RM starting its timeline collector
> ---------------------------------------------------------------
>
>                 Key: YARN-3034
>                 URL: https://issues.apache.org/jira/browse/YARN-3034
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>            Reporter: Sangjin Lee
>            Assignee: Naganarasimha G R
>         Attachments: YARN-3034-20150312-1.patch, YARN-3034.20150205-1.patch, 
> YARN-3034.20150316-1.patch, YARN-3034.20150318-1.patch, 
> YARN-3034.20150320-1.patch
>
>
> Per design in YARN-2928, implement resource managers starting their own ATS 
> writers.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to