[
https://issues.apache.org/jira/browse/YARN-3443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14481471#comment-14481471
]
Sidharta Seethana commented on YARN-3443:
-----------------------------------------
Thanks for the review, [~vvasudev] . Responses below :
1. I could change such log lines to use StringBuffer everywhere. However, I
think a metric based on calls to LOG.warn()/LOG.error() does not accurately
reflect the warn/error 'even't count.
2. I'll add an info log line to the if block. I had added this block for better
readability since the behavior here is a little different from the current
implementation in CgroupsLCEResourcesHandler
3. - 4. Same comment as 1.
5. Sure, I can make this change.
6. This is by design. Otherwise, every resource handler implementation that
uses cgroups will have to check if cgroup mounting is enabled or not (which is
error-prone). It seemed better to instead ignore a mount request when cgroup
mounting is disabled.
7. I'll fix it.
8. I'll fix it.
9. I'll fix it.
10. Yikes. Yes, I'll fix it. Not sure how this one got through.
11. I had added it for clarity, but maybe it isn't necessary. I'll remove it.
12. I'll fix it.
13. I applied a formatter to all file before creating the patch - but, I'll
verify.
> Create a 'ResourceHandler' subsystem to ease addition of support for new
> resource types on the NM
> -------------------------------------------------------------------------------------------------
>
> Key: YARN-3443
> URL: https://issues.apache.org/jira/browse/YARN-3443
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: nodemanager
> Reporter: Sidharta Seethana
> Assignee: Sidharta Seethana
> Attachments: YARN-3443.001.patch, YARN-3443.002.patch
>
>
> The current cgroups implementation is closely tied to supporting CPU as a
> resource . We need to separate out CGroups support as well a provide a simple
> ResourceHandler subsystem that will enable us to add support for new resource
> types on the NM - e.g Network, Disk etc.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
