Varun Vasudev commented on YARN-3443:

Minor documentation fixes, everything else looks good.

# In PrivilegedOperationExecutor.java, getPrivilegedOperationExecutionCommand 
is documented as throwing ExitCodeException but it doesn't throw it.
# In CGroupsHandler.java, the documentation for createCGroup is missing 
descriptions for controller and path.

> Create a 'ResourceHandler' subsystem to ease addition of support for new 
> resource types on the NM
> -------------------------------------------------------------------------------------------------
>                 Key: YARN-3443
>                 URL: https://issues.apache.org/jira/browse/YARN-3443
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: nodemanager
>            Reporter: Sidharta Seethana
>            Assignee: Sidharta Seethana
>         Attachments: YARN-3443.001.patch, YARN-3443.002.patch, 
> YARN-3443.003.patch
> The current cgroups implementation is closely tied to supporting CPU as a 
> resource . We need to separate out CGroups support as well a provide a simple 
> ResourceHandler subsystem that will enable us to add support for new resource 
> types on the NM - e.g Network, Disk etc. 

This message was sent by Atlassian JIRA

Reply via email to