[
https://issues.apache.org/jira/browse/YARN-3443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14486499#comment-14486499
]
Sidharta Seethana commented on YARN-3443:
-----------------------------------------
Thanks for the review, [~djp] . Responses below :
1. I was trying to keep the 'enabled' check consistent between various log
levels as a general practice. I could remove it, though.
2. "We should separate annotation from the line of calss definition. " - this
was by accident. I'll fix it. Its not a public class by design, it is meant to
be used only within the resources package (Custom resource handlers are added
to this package).
3. teardown is one word, hence no camel-case :)
I'll wait for further review comments from you before uploading a new patch,
thanks!
> Create a 'ResourceHandler' subsystem to ease addition of support for new
> resource types on the NM
> -------------------------------------------------------------------------------------------------
>
> Key: YARN-3443
> URL: https://issues.apache.org/jira/browse/YARN-3443
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: nodemanager
> Reporter: Sidharta Seethana
> Assignee: Sidharta Seethana
> Attachments: YARN-3443.001.patch, YARN-3443.002.patch,
> YARN-3443.003.patch, YARN-3443.004.patch
>
>
> The current cgroups implementation is closely tied to supporting CPU as a
> resource . We need to separate out CGroups support as well a provide a simple
> ResourceHandler subsystem that will enable us to add support for new resource
> types on the NM - e.g Network, Disk etc.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
