[
https://issues.apache.org/jira/browse/YARN-3225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14485071#comment-14485071
]
Devaraj K commented on YARN-3225:
---------------------------------
Thanks [~djp] for your review.
bq. I think we should support a case that Admin want node get decommissioned
whenever all apps on these node get finished. If so, shall we support nigative
value (anyone or some special one, like: -1) to specify this case?
If the user wants to achieve this, they can give some larger timeout value and
wait for all nodes to get decommissioned gracefully(without forceful). Do we
really need to provide special handling for this case?
bq. For NORMAL, shall we use "Decommission nodes in normal (old) way" instead
or something simpler- "Decommission nodes"?
I feel "Decommission nodes in normal way" would be ok, no need to mention the
'old' term. What is your opinion on this?
bq. IMO, the methods inside a class should't be more public than class itself?
If we don't expect other projects to use class, we alwasy don't expect some
methods get used. The same problem happen in an old API
RefreshNodeRequest.java. I think we may need to fix both?
I agree, I will fix both of them.
bq. Why do we need this change?
recordFactory.newRecordInstance(RefreshNodesRequest.class) will return
something with DecommissionType.NORMAL as default. No?
It will not give any difference because the NORMAL is the default. I made this
change to make it consistent with other decommission types.
> New parameter or CLI for decommissioning node gracefully in RMAdmin CLI
> -----------------------------------------------------------------------
>
> Key: YARN-3225
> URL: https://issues.apache.org/jira/browse/YARN-3225
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Junping Du
> Assignee: Devaraj K
> Attachments: YARN-3225-1.patch, YARN-3225-2.patch, YARN-3225-3.patch,
> YARN-3225.patch, YARN-914.patch
>
>
> New CLI (or existing CLI with parameters) should put each node on
> decommission list to decommissioning status and track timeout to terminate
> the nodes that haven't get finished.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
